Example code should pass JSHint and generally look good #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is it for now. If I've missed anything, let me know. |
|
Wow... I'm so incredibly late here. Not even funny. Thanks for your changes! We definitely need to improve this code quality. I'm not sure what happened but it looks like this PR includes commits against multiple branches? It looks like a mix of merges against If you'd like to break up this PR into multiple PRs against the different branches, I'd be happy to review. If not, I'm just going to copy your changes into the respective branches and will most likely be closing the PR. Let me know what you'd like to do. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys! Quick PR fixing and prettifying some of the code.
I'll be adding more commits to this on the go, let me know if I'm doing something wrong!